Replace long[] arrays by a TileIndex abstraction #1314
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dealing with `long[]` everywhere and knowing it means `{x,y,z}` is
tiring.
Introducing a `TileIndex` abstraction improves the semantics, and at the
same time allows to save memory on TileObject by storing the
coordinates as internal long,long,int fields and saving the object
reference to a `long` array.
---
> This is a **proposal**. Can we please stop using `long[]` everywhere?
> If accepted, there would be more places to get rid of `long` arrays
> and introduce higher level abstractions (e.g. `TileRangeInterator`)
groldan
force-pushed
the
split_tileobject_xyz
branch
from
8b494e4 to
27e5d87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dealing with
long[]everywhere and knowing it means{x,y,z}is tiring.Introducing a
TileIndexabstraction improves the semantics, and at the same time allows to save memory on TileObject by storing the coordinates as internal long,long,int fields and saving the object reference to alongarray.